Fixup severe build performance issues
Make variable substitution calling bumpversion and other commands
introduce by osmo-release.mk has severely slowed down builds.
Inside the makefile we could use $(eval FOO:=$(shell...)) constructs
to have variable substitution only happen once the 'release' target
is executed. However, 'ifeq' and friends don't work with such late
constructs. Let's shift all release action into a helper shell script
that is called from the Makefile instead.
This way we get the best of both worlds: No performance impact during
normal builds, and the convenience of 'make release'.
Modified-by: Max <msuraev@sysmocom.de>
Related: OS#2524
Change-Id: I98b3b5fe3db39953cea969a9dfbb75889df2e1ea
diff --git a/osmo-release.mk b/osmo-release.mk
index 40eb121..01285b1 100644
--- a/osmo-release.mk
+++ b/osmo-release.mk
@@ -2,43 +2,8 @@
REL := patch
endif
-BUMPVER := $(shell bumpversion)
-NEW_VER := $(shell bumpversion --list --current-version $(VERSION) $(REL) --allow-dirty | awk -F '=' '{ print $$2 }')
-LIBVERS := $(shell git grep -n LIBVERSION | grep '=' | grep am | grep -v LDFLAGS)
-MAKEMOD := $(shell git diff -GLIBVERSION --stat | grep Makefile.am)
-ISODATE := $(shell date -I)
-
release:
-
-ifeq ($(BUMPVER),)
- @$(error Unable to find 'bumpversion' command.)
-endif
-
-ifeq ($(NEW_VER),)
- @$(error Please fix versioning to match http://semver.org/ spec (current is $(VERSION)) before proceeding.)
-endif
-
ifeq ($(origin REL), file)
@echo "No REL value specified, defaulting to 'patch' release"
endif
-
- @echo "Releasing" $(VERSION) "->" $(NEW_VER)"..."
-
-ifeq ($(LIBVERS),)
- @gbp dch --debian-tag='%(version)s' --auto --meta --git-author --multimaint-merge --ignore-branch
-else
- @echo "You should NOT be doing this unless you've read and understood following article:"
- @echo "https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html#Updating-version-info"
- @grep -v '#' TODO-RELEASE | sed 's/\t\+/: /g' > TODO-RELEASE.entries
- @grep '#' TODO-RELEASE > TODO-RELEASE.clean
- @mv TODO-RELEASE.clean TODO-RELEASE
-ifeq ($(MAKEMOD),)
- @$(if $(shell git status -s -uno TODO-RELEASE),,$(error Before releasing, please modify some of the libversions: $(LIBVERS)))
-endif
- @xargs -a TODO-RELEASE.entries -r -d'\n' -I entry dch -m -v $(NEW_VER) "entry"
-endif
- @dch -r -m --distribution "unstable" ""
- @git add -u
- @bumpversion --current-version $(VERSION) $(REL) --tag --commit --tag-name $(NEW_VER) --allow-dirty
- @git tag -s $(NEW_VER) -f -m "Release v$(NEW_VER) on $(ISODATE)."
- @echo "Release" $(NEW_VER) "prepared, tagged and signed."
+ @osmo-release.sh $(VERSION) $(REL)