commit e5a2bdbc5501b892605a6a1fe7e30fb2f1546d42
author Neels Hofmeyr <neels@hofmeyr.de> Sat Dec 16 04:54:37 2017 +0100
committer Neels Hofmeyr <nhofmeyr@sysmocom.de> Sun Dec 17 21:57:55 2017 +0000
tree 818bcbbb1116966182f46d67bff60d01ff12e359
parent 3ef14a241afc123560e9a50d17948b040481b299

fix osmo_identifier_valid(): only allow printable characters

In particular disallow ASCII 0..31 (control characters) and 127 (DEL).

Change-Id: I04469988495af03c881fe81d7786ca7f71636299

src/utils.c

diff --git a/src/utils.c b/src/utils.c
index bc5329d..8f56227 100644
--- a/src/utils.c
+++ b/src/utils.c
@@ -444,6 +444,8 @@
 		/* check for 7-bit ASCII */
 		if (str[i] & 0x80)
 			return false;
+		if (!isprint((int)str[i]))
+			return false;
 		/* check for some explicit reserved control characters */
 		if (strchr(illegal_chars, str[i]))
 			return false;