tree caf6d01c70df12ca7796374df5e46454df39b965
parent 8f25fd27ed35d6cb47b5e57aea632d088b69bfe0
author Pau Espin Pedrol <pespin@sysmocom.de> 1652440041 +0200
committer Pau Espin Pedrol <pespin@sysmocom.de> 1652440043 +0200

coding: Refactor function to avoid gcc false positive warn

"""
/libosmocore/src/coding/gsm0503_coding.c: In function 'osmo_conv_decode_ber_punctured':
/libosmocore/src/coding/gsm0503_coding.c:563:31: error: 'coded_len' may be used uninitialized [-Werror=maybe-uninitialized]
  563 |                 *n_bits_total = coded_len;
      |                 ~~~~~~~~~~~~~~^~~~~~~~~~~
/libosmocore/src/coding/gsm0503_coding.c:541:21: note: 'coded_len' was declared here
  541 |         int res, i, coded_len;
      |                     ^~~~~~~~~
"""

This error is really a false positive. However, it is true that the code
used to be a bit more complex than required, since the 2 later conditions
could be inside the first one.
Let's simply do early termination to simplify the function, and get rid
of the gcc warning.

Change-Id: I31ebf0c4be61daf6395d9a9fac05c7fdceb8bcb9