Gitiles
Code Review Sign In
gerrit.osmocom.org / libosmocore / cc9b6999314391b5ba10a26795504aa123d84f00
commitcc9b6999314391b5ba10a26795504aa123d84f00[log] [tgz]
authorNeels Hofmeyr <nhofmeyr@sysmocom.de>Mon May 01 02:59:01 2023 +0200
committerneels <nhofmeyr@sysmocom.de>Sat May 06 03:49:08 2023 +0000
tree48e75724d55c2038ffbf25208db4ad7db9a8c824
parent4cf72df3f9518ff306a0ecd89a890c9095addeac [diff]
vty: show bug in implicit go_parent_node

Add test to show a problem in VTY node exiting.

Back in 2017 when I introduced VTY config file scopes by indenting [1],
I actually mistook the vty->priv for the vty->index that we use
everywhere to link to the state for our VTY nodes.

The intention was that each VTY node child level has its own object
linked to it by the vty->index pointer. When the config file leaves a
scope, the vty->index should reflect the parent object.

Instead I implemented that for the vty->priv pointer only, but we don't
use that.

Why did this bug not show? A problem happens only if:
- a node that uses vty->index is nested inside a node that also uses
  vty->index.
- config sets parent node attributes after a child node.
- there is no legacy vty_go_parent() function that sets the correct
  index via a switch().

[1]
"VTY: implicit node exit by de-indenting, not parent lookup"
4a31ffa2f0097d96201f80305a0495c57552f0ad
I24cbb3f6de111f2d31110c3c484c066f1153aac9

Change-Id: I2472daed7436a1947655b06d34eb217e595bc7f3
2 files changed
tree: 48e75724d55c2038ffbf25208db4ad7db9a8c824
  1. contrib/
  2. debian/
  3. doc/
  4. include/
  5. m4/
  6. src/
  7. tapset/
  8. tests/
  9. utils/
  10. .gitignore
  11. .gitreview
  12. .mailmap
  13. configure.ac
  14. COPYING
  15. Doxyfile.codec.in
  16. Doxyfile.coding.in
  17. Doxyfile.core.in
  18. Doxyfile.ctrl.in
  19. Doxyfile.gb.in
  20. Doxyfile.gsm.in
  21. Doxyfile.isdn.in
  22. Doxyfile.sim.in
  23. Doxyfile.usb.in
  24. Doxyfile.vty.in
  25. git-version-gen
  26. libosmocodec.pc.in
  27. libosmocoding.pc.in
  28. libosmocore.pc.in
  29. libosmoctrl.pc.in
  30. libosmogb.pc.in
  31. libosmogsm.pc.in
  32. libosmoisdn.pc.in
  33. libosmosim.pc.in
  34. libosmousb.pc.in
  35. libosmovty.pc.in
  36. Makefile.am
  37. osmo-release.mk
  38. osmo-release.sh
  39. README.md
  40. TODO-RELEASE
README.md

libosmocore - set of Osmocom core libraries

This repository contains a set of C-language libraries that form the core infrastructure of many Osmocom Open Source Mobile Communications projects.

Historically, a lot of this code was developed as part of the OpenBSC project, but which are of a more generic nature and thus useful to (at least) other programs that we develop in the sphere of Free Software / Open Source mobile communications.

There is no clear scope of it. We simply move all shared code between the various Osmocom projects in this library to avoid code duplication.

The libosmocore.git repository build multiple libraries:

  • libosmocore contains some general-purpose functions like select-loop abstraction, message buffers, timers, linked lists
  • libosmovty contains routines related to the interactive command-line interface called VTY
  • libosmogsm contains definitions and helper code related to GSM protocols
  • libosmoctrl contains a shared implementation of the Osmocom control interface
  • libosmogb contains an implementation of the Gb interface with its NS/BSSGP protocols
  • libosmocodec contains an implementation of GSM voice codecs
  • libosmocoding contains an implementation of GSM channel coding
  • libosmosim contains infrastructure to interface SIM/UICC/USIM cards

Homepage

The official homepage of the project is https://osmocom.org/projects/libosmocore/wiki/Libosmocore

GIT Repository

You can clone from the official libosmocore.git repository using

git clone https://gitea.osmocom.org/osmocom/libosmocore

There is a web interface at https://gitea.osmocom.org/osmocom/libosmocore

Documentation

Doxygen-generated API documentation is generated during the build process, but also available online for each of the sub-libraries at https://ftp.osmocom.org/api/latest/libosmocore/

Mailing List

Discussions related to libosmocore are happening on the openbsc@lists.osmocom.org mailing list, please see https://lists.osmocom.org/mailman/listinfo/openbsc for subscription options and the list archive.

Please observe the Osmocom Mailing List Rules when posting.

Contributing

Our coding standards are described at https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards

We us a gerrit based patch submission/review process for managing contributions. Please see https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit for more details

The current patch queue for libosmocore can be seen at https://gerrit.osmocom.org/#/q/project:libosmocore+status:open