vty: Avoid ultra-long multi-line strings cluttering talloc reports
The talloc_asprintf() series includes an unconditional call to
talloc_set_name_const(), turning the entire long constructed string
into the name of the talloc object. That simply doesn't work when
creating kilobytes-sized VTY reference strings including linefeeds.
Let's add an explicit talloc_set_name_const() to prevent this.
Change-Id: Ibd77684b88cc3572047daa98c9a6b9119fba041b
Closes: OS#4668
diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c
index c51b437..0e1782a 100644
--- a/src/vty/logging_vty.c
+++ b/src/vty/logging_vty.c
@@ -337,6 +337,9 @@
osmo_talloc_asprintf(tall_log_ctx, cmd_str, ") %s", level_args);
osmo_talloc_asprintf(tall_log_ctx, doc_str, "%s", level_strs);
+ talloc_set_name_const(cmd_str, "vty_log_level_cmd_str");
+ talloc_set_name_const(doc_str, "vty_log_level_doc_str");
+
cmd->string = cmd_str;
cmd->doc = doc_str;
}
@@ -1048,6 +1051,9 @@
osmo_talloc_asprintf(tall_log_ctx, doc_str,
"Arbitrary message to log on given category and log level\n");
+ talloc_set_name_const(cmd_str, "vty_logp_cmd_str");
+ talloc_set_name_const(doc_str, "vty_logp_doc_str");
+
cmd->string = cmd_str;
cmd->doc = doc_str;
}