commit bdfb8b9104fde2a053f86953ecbbdb1b2f265b9d
author Harald Welte <laforge@osmocom.org> Sun Jan 31 11:44:57 2021 +0100
committer Harald Welte <laforge@osmocom.org> Mon Feb 01 09:39:29 2021 +0100
tree 0fb01a9fabc8627961d9c2b1b5e367f5b586bdcf
parent c3aa8f903a58db8af5c2687a3c040fe9f49474fb

ns2: Memory allocation failures are ENOMEM, not ENOSPC

ENOSPC is used with non-volatile (disk) storage, while ENOMEM is
customarily used for RAM allocation failures.

Change-Id: Ia4c16d8278dc30c7cc69169b18428cda5272738d

src/gb/gprs_ns2.c

diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c
index 4f3bc5e..2dde693 100644
--- a/src/gb/gprs_ns2.c
+++ b/src/gb/gprs_ns2.c
@@ -1367,12 +1367,12 @@
 
 	bind = talloc_zero(nsi, struct gprs_ns2_vc_bind);
 	if (!bind)
-		return -ENOSPC;
+		return -ENOMEM;
 
 	bind->name = talloc_strdup(bind, name);
 	if (!bind->name) {
 		talloc_free(bind);
-		return -ENOSPC;
+		return -ENOMEM;
 	}
 
 	bind->nsi = nsi;

src/gb/gprs_ns2_fr.c

diff --git a/src/gb/gprs_ns2_fr.c b/src/gb/gprs_ns2_fr.c
index 953f4ca..c32bce8 100644
--- a/src/gb/gprs_ns2_fr.c
+++ b/src/gb/gprs_ns2_fr.c
@@ -738,7 +738,7 @@
 	bind->dump_vty = dump_vty;
 	priv = bind->priv = talloc_zero(bind, struct priv_bind);
 	if (!priv) {
-		rc = -ENOSPC;
+		rc = -ENOMEM;
 		goto err_bind;
 	}
 

src/gb/gprs_ns2_frgre.c

diff --git a/src/gb/gprs_ns2_frgre.c b/src/gb/gprs_ns2_frgre.c
index 863f8f2..88ef037 100644
--- a/src/gb/gprs_ns2_frgre.c
+++ b/src/gb/gprs_ns2_frgre.c
@@ -565,7 +565,7 @@
 	priv = bind->priv = talloc_zero(bind, struct priv_bind);
 	if (!priv) {
 		gprs_ns2_free_bind(bind);
-		return -ENOSPC;
+		return -ENOMEM;
 	}
 	priv->fd.cb = frgre_fd_cb;
 	priv->fd.data = bind;

src/gb/gprs_ns2_udp.c

diff --git a/src/gb/gprs_ns2_udp.c b/src/gb/gprs_ns2_udp.c
index b4bcd01..9277f9a 100644
--- a/src/gb/gprs_ns2_udp.c
+++ b/src/gb/gprs_ns2_udp.c
@@ -341,7 +341,7 @@
 	priv = bind->priv = talloc_zero(bind, struct priv_bind);
 	if (!priv) {
 		gprs_ns2_free_bind(bind);
-		return -ENOSPC;
+		return -ENOMEM;
 	}
 	priv->fd.cb = nsip_fd_cb;
 	priv->fd.data = bind;