commit b89114b3faf1f91131c32792e2880e35d2131143
author Vadim Yanitskiy <vyanitskiy@sysmocom.de> Wed Sep 09 04:51:04 2020 +0700
committer Vadim Yanitskiy <vyanitskiy@sysmocom.de> Wed Sep 09 05:00:15 2020 +0700
tree 387501d7964cbaa14182ec088ff560de460d7999
parent 04f427170413b81801c1ff9445118d5795e609b1

logging: fix memleak in log_target_create_file()

Change-Id: If16d8c6417698bbb5cf87716f9507c7256aeaecb

src/logging.c

diff --git a/src/logging.c b/src/logging.c
index 80ff72c..db04cf7 100644
--- a/src/logging.c
+++ b/src/logging.c
@@ -915,8 +915,10 @@
 
 	target->type = LOG_TGT_TYPE_FILE;
 	target->tgt_file.out = fopen(fname, "a");
-	if (!target->tgt_file.out)
+	if (!target->tgt_file.out) {
+		log_target_destroy(target);
 		return NULL;
+	}
 
 	target->output = _file_output;
 
@@ -966,6 +968,8 @@
 #if (!EMBEDDED)
 	switch (target->type) {
 	case LOG_TGT_TYPE_FILE:
+		if (target->tgt_file.out == NULL)
+			break;
 		fclose(target->tgt_file.out);
 		target->tgt_file.out = NULL;
 		break;