Gitiles
Code Review Sign In
gerrit.osmocom.org / libosmocore / b54229d2ecefc3b56169c55f723fad4801a570be
commitb54229d2ecefc3b56169c55f723fad4801a570be[log] [tgz]
authorNeels Hofmeyr <nhofmeyr@sysmocom.de>Tue Mar 08 23:41:23 2022 +0100
committerNeels Hofmeyr <nhofmeyr@sysmocom.de>Tue Mar 08 23:41:23 2022 +0100
tree5e421e631273ed2497f6b32d3dbc56e657352f82
parentef872cb7ad39172a1d8047a0d7696292edbf50bd [diff]
osmo_time_cc: rate_ctr presence should not affect counting

Make sure that osmo_time_cc counts exactly the same, regardless of a
rate_ctr being present or not. Only skip sending counter increments when
there is no rate counter, do not affect anything else.

In osmo-bsc, we are discussing a patch where an lchan redirects
osmo_time_cc counter increments to different rate counters depending on
its current type. In my comments I am also claiming that osmo_time_cc
works the same regardless of a rate_ctr being present or not. Looking at
the code, this is not actually the case.

Before this patch, when there is no rate_ctr, the reported_sum would
freeze, and as soon as a rate_ctr shows up, all counter increments from
the previous reported_sum would be sent to the newly set rate_ctr.
Instead, we want counter increments to simply be lost while there is no
rate_ctr set. IOW, rate_ctr == NULL should mean >/dev/null.

Related: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 (osmo-bsc)
Change-Id: I380b28d7ab0a6c8aab6c7e2a64bc73cab14863d2
1 file changed
tree: 5e421e631273ed2497f6b32d3dbc56e657352f82
  1. contrib/
  2. debian/
  3. doc/
  4. include/
  5. m4/
  6. src/
  7. tapset/
  8. tests/
  9. utils/
  10. .gitignore
  11. .gitreview
  12. .mailmap
  13. configure.ac
  14. COPYING
  15. Doxyfile.codec.in
  16. Doxyfile.coding.in
  17. Doxyfile.core.in
  18. Doxyfile.ctrl.in
  19. Doxyfile.gb.in
  20. Doxyfile.gsm.in
  21. Doxyfile.vty.in
  22. git-version-gen
  23. libosmocodec.pc.in
  24. libosmocoding.pc.in
  25. libosmocore.pc.in
  26. libosmoctrl.pc.in
  27. libosmogb.pc.in
  28. libosmogsm.pc.in
  29. libosmosim.pc.in
  30. libosmousb.pc.in
  31. libosmovty.pc.in
  32. Makefile.am
  33. osmo-release.mk
  34. osmo-release.sh
  35. README.md
  36. TODO-RELEASE
README.md

libosmocore - set of Osmocom core libraries

This repository contains a set of C-language libraries that form the core infrastructure of many Osmocom Open Source Mobile Communications projects.

Historically, a lot of this code was developed as part of the OpenBSC project, but which are of a more generic nature and thus useful to (at least) other programs that we develop in the sphere of Free Software / Open Source mobile communications.

There is no clear scope of it. We simply move all shared code between the various Osmocom projects in this library to avoid code duplication.

The libosmocore.git repository build multiple libraries:

  • libosmocore contains some general-purpose functions like select-loop abstraction, message buffers, timers, linked lists
  • libosmovty contains routines related to the interactive command-line interface called VTY
  • libosmogsm contains definitions and helper code related to GSM protocols
  • libosmoctrl contains a shared implementation of the Osmocom control interface
  • libosmogb contains an implementation of the Gb interface with its NS/BSSGP protocols
  • libosmocodec contains an implementation of GSM voice codecs
  • libosmocoding contains an implementation of GSM channel coding
  • libosmosim contains infrastructure to interface SIM/UICC/USIM cards

Homepage

The official homepage of the project is https://osmocom.org/projects/libosmocore/wiki/Libosmocore

GIT Repository

You can clone from the official libosmocore.git repository using

git clone git://git.osmocom.org/libosmocore.git

There is a cgit interface at https://git.osmocom.org/libosmocore/

Documentation

Doxygen-generated API documentation is generated during the build process, but also available online for each of the sub-libraries at https://ftp.osmocom.org/api/latest/libosmocore/

Mailing List

Discussions related to libosmocore are happening on the openbsc@lists.osmocom.org mailing list, please see https://lists.osmocom.org/mailman/listinfo/openbsc for subscription options and the list archive.

Please observe the Osmocom Mailing List Rules when posting.

Contributing

Our coding standards are described at https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards

We us a gerrit based patch submission/review process for managing contributions. Please see https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit for more details

The current patch queue for libosmocore can be seen at https://gerrit.osmocom.org/#/q/project:libosmocore+status:open