Gitiles
Code Review Sign In
gerrit.osmocom.org / libosmocore / 9c603e64bf553ac282af8534a2d7592f719d092f
commit9c603e64bf553ac282af8534a2d7592f719d092f[log] [tgz]
authorVadim Yanitskiy <vyanitskiy@sysmocom.de>Sun Dec 10 17:09:23 2023 +0700
committerneels <nhofmeyr@sysmocom.de>Mon Dec 11 04:07:31 2023 +0000
tree6919424f27a0caf863e599782e8509a5b8a36712
parentd2e8f67f3d046b29c4f3f959673b028babd6ec93 [diff]
logging: fix NULL pointer dereference in _output_buf()

In the _output_buf() we explicitly initialize only the 'buf' and 'len'
fields of the struct osmo_strbuf, leaving the 'pos' field implicitly
initialized to NULL.  Later, in this function, 'sb.pos' is passed to
ctime_r() and strlen(), leading to a NULL pointer dereference (segfault)
in certain scenarios.

This situation can occur when color logging is disabled or when
a specific logging subsystem has no associated color.  Any application
using libosmocore's logging API would crash with the following config:

log stderr
 logging filter all 1
 logging timestamp 1
 logging color 0

Fix this by initializing the 'pos' field explicitly.

Change-Id: I7ec9badf525e03e54e10b725d820c636eaa3fd1c
Fixes: d71331bc "logging: fix nul octets in log output / use osmo_strbuf"
Fixes: CID#336550
1 file changed
tree: 6919424f27a0caf863e599782e8509a5b8a36712
  1. contrib/
  2. debian/
  3. doc/
  4. include/
  5. m4/
  6. src/
  7. tapset/
  8. tests/
  9. utils/
  10. .checkpatch.conf
  11. .gitignore
  12. .gitreview
  13. .mailmap
  14. configure.ac
  15. COPYING
  16. Doxyfile.codec.in
  17. Doxyfile.coding.in
  18. Doxyfile.core.in
  19. Doxyfile.ctrl.in
  20. Doxyfile.gb.in
  21. Doxyfile.gsm.in
  22. Doxyfile.isdn.in
  23. Doxyfile.sim.in
  24. Doxyfile.usb.in
  25. Doxyfile.vty.in
  26. git-version-gen
  27. libosmocodec.pc.in
  28. libosmocoding.pc.in
  29. libosmocore.pc.in
  30. libosmoctrl.pc.in
  31. libosmogb.pc.in
  32. libosmogsm.pc.in
  33. libosmoisdn.pc.in
  34. libosmosim.pc.in
  35. libosmousb.pc.in
  36. libosmovty.pc.in
  37. Makefile.am
  38. osmo-release.mk
  39. osmo-release.sh
  40. README.md
  41. TODO-RELEASE
README.md

libosmocore - set of Osmocom core libraries

This repository contains a set of C-language libraries that form the core infrastructure of many Osmocom Open Source Mobile Communications projects.

Historically, a lot of this code was developed as part of the OpenBSC project, but which are of a more generic nature and thus useful to (at least) other programs that we develop in the sphere of Free Software / Open Source mobile communications.

There is no clear scope of it. We simply move all shared code between the various Osmocom projects in this library to avoid code duplication.

The libosmocore.git repository build multiple libraries:

  • libosmocore contains some general-purpose functions like select-loop abstraction, message buffers, timers, linked lists
  • libosmovty contains routines related to the interactive command-line interface called VTY
  • libosmogsm contains definitions and helper code related to GSM protocols
  • libosmoctrl contains a shared implementation of the Osmocom control interface
  • libosmogb contains an implementation of the Gb interface with its NS/BSSGP protocols
  • libosmocodec contains an implementation of GSM voice codecs
  • libosmocoding contains an implementation of GSM channel coding
  • libosmosim contains infrastructure to interface SIM/UICC/USIM cards

Homepage

The official homepage of the project is https://osmocom.org/projects/libosmocore/wiki/Libosmocore

GIT Repository

You can clone from the official libosmocore.git repository using

git clone https://gitea.osmocom.org/osmocom/libosmocore

There is a web interface at https://gitea.osmocom.org/osmocom/libosmocore

Documentation

Doxygen-generated API documentation is generated during the build process, but also available online for each of the sub-libraries at https://ftp.osmocom.org/api/latest/libosmocore/

Mailing List

Discussions related to libosmocore are happening on the openbsc@lists.osmocom.org mailing list, please see https://lists.osmocom.org/mailman/listinfo/openbsc for subscription options and the list archive.

Please observe the Osmocom Mailing List Rules when posting.

Contributing

Our coding standards are described at https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards

We us a gerrit based patch submission/review process for managing contributions. Please see https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit for more details

The current patch queue for libosmocore can be seen at https://gerrit.osmocom.org/#/q/project:libosmocore+status:open