Gitiles
Code Review Sign In
gerrit.osmocom.org / libosmocore / 8d42394c89abdad60d603da42ebeb9ea66cfe716
commit8d42394c89abdad60d603da42ebeb9ea66cfe716[log] [tgz]
authorNeels Hofmeyr <nhofmeyr@sysmocom.de>Thu Jun 08 00:35:41 2023 +0200
committerNeels Hofmeyr <nhofmeyr@sysmocom.de>Thu Jun 08 00:55:40 2023 +0200
treef8ebf46b6465f9ce572dae057bfc3bb059c4f577
parenteb9edbab54463cb705ec7b770e022a215ce503c7 [diff]
improve API for osmo_routing_area_id

Code review for [1] has asked for providing proper API for struct
osmo_routing_area_id.

For historical reasons, we have struct gprs_ra_id and
struct osmo_routing_area_id serving the exact same purpose: represent a
decoded 3GPP TS 24.008 ยง 10.5.5.15 Routing area identification.

The "better" one is struct osmo_routing_area_id: it allows using API
like osmo_plmn_cmp(), because it is made up of meaningful sub-structs.

Implement de/coding using the functions already available for the
sub-struct osmo_location_area_id, and simply add the RAC.

Add a test in gsm0408_test.c.

Note that other utility functions are already available for struct
osmo_routing_area_id: osmo_rai_name2(), osmo_rai_cmp().

There is no real need to deprecate struct gprs_ra_id, because there is
not really anything wrong with it. It just isn't as well integrated with
other utility API as struct osmo_routing_area_id is. Just add comments.

[1] osmo-hnbgw.git:
    cnpool: extract Mobile Identity from RANAP payload
    https://gerrit.osmocom.org/c/osmo-hnbgw/+/33133
    I373d665c9684b607207f68094188eab63209db51

Change-Id: Ic5e0406d9e20b0d4e1372fa30ba11a1e69f5cc94
5 files changed
tree: f8ebf46b6465f9ce572dae057bfc3bb059c4f577
  1. contrib/
  2. debian/
  3. doc/
  4. include/
  5. m4/
  6. src/
  7. tapset/
  8. tests/
  9. utils/
  10. .checkpatch.conf
  11. .gitignore
  12. .gitreview
  13. .mailmap
  14. configure.ac
  15. COPYING
  16. Doxyfile.codec.in
  17. Doxyfile.coding.in
  18. Doxyfile.core.in
  19. Doxyfile.ctrl.in
  20. Doxyfile.gb.in
  21. Doxyfile.gsm.in
  22. Doxyfile.isdn.in
  23. Doxyfile.sim.in
  24. Doxyfile.usb.in
  25. Doxyfile.vty.in
  26. git-version-gen
  27. libosmocodec.pc.in
  28. libosmocoding.pc.in
  29. libosmocore.pc.in
  30. libosmoctrl.pc.in
  31. libosmogb.pc.in
  32. libosmogsm.pc.in
  33. libosmoisdn.pc.in
  34. libosmosim.pc.in
  35. libosmousb.pc.in
  36. libosmovty.pc.in
  37. Makefile.am
  38. osmo-release.mk
  39. osmo-release.sh
  40. README.md
  41. TODO-RELEASE
README.md

libosmocore - set of Osmocom core libraries

This repository contains a set of C-language libraries that form the core infrastructure of many Osmocom Open Source Mobile Communications projects.

Historically, a lot of this code was developed as part of the OpenBSC project, but which are of a more generic nature and thus useful to (at least) other programs that we develop in the sphere of Free Software / Open Source mobile communications.

There is no clear scope of it. We simply move all shared code between the various Osmocom projects in this library to avoid code duplication.

The libosmocore.git repository build multiple libraries:

  • libosmocore contains some general-purpose functions like select-loop abstraction, message buffers, timers, linked lists
  • libosmovty contains routines related to the interactive command-line interface called VTY
  • libosmogsm contains definitions and helper code related to GSM protocols
  • libosmoctrl contains a shared implementation of the Osmocom control interface
  • libosmogb contains an implementation of the Gb interface with its NS/BSSGP protocols
  • libosmocodec contains an implementation of GSM voice codecs
  • libosmocoding contains an implementation of GSM channel coding
  • libosmosim contains infrastructure to interface SIM/UICC/USIM cards

Homepage

The official homepage of the project is https://osmocom.org/projects/libosmocore/wiki/Libosmocore

GIT Repository

You can clone from the official libosmocore.git repository using

git clone https://gitea.osmocom.org/osmocom/libosmocore

There is a web interface at https://gitea.osmocom.org/osmocom/libosmocore

Documentation

Doxygen-generated API documentation is generated during the build process, but also available online for each of the sub-libraries at https://ftp.osmocom.org/api/latest/libosmocore/

Mailing List

Discussions related to libosmocore are happening on the openbsc@lists.osmocom.org mailing list, please see https://lists.osmocom.org/mailman/listinfo/openbsc for subscription options and the list archive.

Please observe the Osmocom Mailing List Rules when posting.

Contributing

Our coding standards are described at https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards

We us a gerrit based patch submission/review process for managing contributions. Please see https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit for more details

The current patch queue for libosmocore can be seen at https://gerrit.osmocom.org/#/q/project:libosmocore+status:open