commit 836c6dac65bcff554f4506379713e5fb52084219
author Philipp Maier <pmaier@sysmocom.de> Tue Jan 19 20:03:50 2021 +0100
committer laforge <laforge@osmocom.org> Wed Jan 20 16:09:00 2021 +0000
tree 018a171ff5aa9673b0c43251f49807ec61aeada4
parent 191c2d7de975bf6d4c384e21bf98f6bd5a807935

gprs_bssgp_rim: Return with EOPNOTSUPP on unsupported containers

The current version of libosmocore only supports NACC related RIM
application containers. If the parser detects a different application
container it returns with EINVAL. Unfortunately this means that the
caller can not distinguish if there is a lack of support or a real
parsing error.

Change-Id: Ib5ada3554c04259764352888cf95bc4460cb2a54
Related: SYS#5103

src/gb/gprs_bssgp_rim.c

diff --git a/src/gb/gprs_bssgp_rim.c b/src/gb/gprs_bssgp_rim.c
index 7094f5f..2096977 100644
--- a/src/gb/gprs_bssgp_rim.c
+++ b/src/gb/gprs_bssgp_rim.c
@@ -405,7 +405,7 @@
 		case BSSGP_RAN_INF_APP_ID_SON:
 		case BSSGP_RAN_INF_APP_ID_UTRA_SI:
 			/* TODO: add parsers for Si3, MBMS, SON, UTRA-SI app containers */
-			return -EINVAL;
+			return -EOPNOTSUPP;
 		default:
 			return -EINVAL;
 		}
@@ -475,7 +475,7 @@
 	case BSSGP_RAN_INF_APP_ID_SON:
 	case BSSGP_RAN_INF_APP_ID_UTRA_SI:
 		/* TODO: add encoders for Si3, MBMS, SON, UTRA-SI app containers */
-		return -EINVAL;
+		return -EOPNOTSUPP;
 	default:
 		return -EINVAL;
 	}
@@ -528,7 +528,7 @@
 		case BSSGP_RAN_INF_APP_ID_SON:
 		case BSSGP_RAN_INF_APP_ID_UTRA_SI:
 			/* TODO: add parsers for Si3, MBMS, SON, UTRA-SI app containers */
-			return -EINVAL;
+			return -EOPNOTSUPP;
 		default:
 			return -EINVAL;
 		}
@@ -547,7 +547,7 @@
 		case BSSGP_RAN_INF_APP_ID_SON:
 		case BSSGP_RAN_INF_APP_ID_UTRA_SI:
 			/* TODO: add parsers for Si3, MBMS, SON, UTRA-SI app containers */
-			return -EINVAL;
+			return -EOPNOTSUPP;
 		default:
 			return -EINVAL;
 		}
@@ -594,7 +594,7 @@
 		case BSSGP_RAN_INF_APP_ID_SON:
 		case BSSGP_RAN_INF_APP_ID_UTRA_SI:
 			/* TODO: add encoders for Si3, MBMS, SON, UTRA-SI app containers */
-			return -EINVAL;
+			return -EOPNOTSUPP;
 		default:
 			return -EINVAL;
 		}
@@ -613,7 +613,7 @@
 		case BSSGP_RAN_INF_APP_ID_SON:
 		case BSSGP_RAN_INF_APP_ID_UTRA_SI:
 			/* TODO: add encoders for Si3, MBMS, SON, UTRA-SI app containers */
-			return -EINVAL;
+			return -EOPNOTSUPP;
 		default:
 			return -EINVAL;
 		}
@@ -810,7 +810,7 @@
 	case BSSGP_RAN_INF_APP_ID_SON:
 	case BSSGP_RAN_INF_APP_ID_UTRA_SI:
 		/* TODO: add parsers for Si3, MBMS, SON, UTRA-SI app containers */
-		return -EINVAL;
+		return -EOPNOTSUPP;
 	default:
 		return -EINVAL;
 	}
@@ -849,7 +849,7 @@
 	case BSSGP_RAN_INF_APP_ID_SON:
 	case BSSGP_RAN_INF_APP_ID_UTRA_SI:
 		/* TODO: add encoders for Si3, MBMS, SON, UTRA-SI app containers */
-		return -EINVAL;
+		return -EOPNOTSUPP;
 	default:
 		return -EINVAL;
 	}