tree e91f5aaf6a4bbdddc018da16ad3e495bbe6082c0
parent c4193d30e82307b87a7a7bce3ea5ed48f2f2f716
author Harald Welte <laforge@gnumonks.org> 1478873433 +0100
committer Harald Welte <laforge@gnumonks.org> 1478875771 +0000

bssgp_rx_paging(): Fix parsing of P-TMSI IE in Paging message

This was actually discovered by the following compiler warning in
gcc-6.2.0:

  CC       gprs_bssgp_bss.lo
gprs_bssgp_bss.c: In function ‘bssgp_rx_paging’:
gprs_bssgp_bss.c:544:2: warning: this ‘if’ clause does not guard...
[-Wmisleading-indentation]
  if (TLVP_PRESENT(&tp, BSSGP_IE_TMSI) &&
  ^~
gprs_bssgp_bss.c:548:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’
   *(pinfo->ptmsi) = ntohl(*(uint32_t *)
   ^

This is an actual bug.  If we recevied a BSSGP Paging Request without
P-TMSI, we might crash or report some random memory as P-TMSI to the
caller in the output data structure.

Change-Id: Ib4f307827cd7cccc91c1415a6fb5428d7cf8416d