gprs_ns2: nsvc_fsm: reorder notification st_alive_on_enter()
The start_procedure() can't be called after ns2_nse_notify_unblocked()
because ns2_nse_notify_unblocked() might free the nsvc.
Otherwise the fsm will do use-after-free on the NSVC memory.
Related: SYS#5416
Change-Id: If97dfd123eefd71fc6c3fe886a243a21784aeeb4
diff --git a/src/gb/gprs_ns2_vc_fsm.c b/src/gb/gprs_ns2_vc_fsm.c
index a8cb570..85cd2ad 100644
--- a/src/gb/gprs_ns2_vc_fsm.c
+++ b/src/gb/gprs_ns2_vc_fsm.c
@@ -460,8 +460,8 @@
if (old_state != GPRS_NS2_ST_RECOVERING)
priv->N = 0;
- ns2_nse_notify_unblocked(priv->nsvc, false);
start_test_procedure(fi, true);
+ ns2_nse_notify_unblocked(priv->nsvc, false);
}
static const struct osmo_fsm_state ns2_vc_states[] = {