commit 55088b76cec00674d2becf7ced4723c5998a0a42
author Pau Espin Pedrol <pespin@sysmocom.de> Thu Jul 12 13:03:52 2018 +0200
committer Harald Welte <laforge@gnumonks.org> Thu Jul 12 18:47:57 2018 +0000
tree 9d4fc705697b23bf2cf11a1b0b067cd41e1fa44e
parent cdd05816dae6d33c6165c7cb4f118b8e4b7c6ab0

ctrl: Log CMD TYPE on invalid ID number

Change-Id: Ia890d4b841ef02342cc1cf7f5926866b040dc8ab

src/ctrl/control_cmd.c

diff --git a/src/ctrl/control_cmd.c b/src/ctrl/control_cmd.c
index bff4d17..c5924b2 100644
--- a/src/ctrl/control_cmd.c
+++ b/src/ctrl/control_cmd.c
@@ -363,10 +363,11 @@
 	}
 
 	if (!id_str_valid(tmp)) {
+		LOGP(DLCTRL, LOGL_NOTICE, "Invalid %s message ID number: \"%s\"\n",
+		     get_value_string(ctrl_type_vals, cmd->type), osmo_escape_str(tmp, -1));
 		cmd->type = CTRL_TYPE_ERROR;
 		cmd->id = "err";
 		cmd->reply = "Invalid message ID number";
-		LOGP(DLCTRL, LOGL_NOTICE, "Invalid message ID number: \"%s\"\n", osmo_escape_str(tmp, -1));
 		goto err;
 	}
 	cmd->id = talloc_strdup(cmd, tmp);