tree 644fe548d60dc1e8856352b2ef53df3fb9c3531a
parent 6f89c770c7bd6ed4919375c31e18de7c17a8a61f
author Neels Hofmeyr <neels@hofmeyr.de> 1608225034 +0100
committer laforge <laforge@osmocom.org> 1608289936 +0000

gprs_ns2_fr.c: compiler error: replace strncpy() with OSMO_STRLCPY_ARRAY()

My gcc (Debian 8.3.0-6) 8.3.0 refuses to build this strncpy() use: it
issues the buffer length as n and thus potentially fails to account for
the terminating nul. The line after that fixes the problem, so it's not
an actual bug. Anyway, we have a policy to never use strncpy(), and have
osmo_strlcpy() and OSMO_STRLCPY_ARRAY() for this.

This strncpy() was introduced last month during first addition of
gprs_ns2_fr.c:

    commit 841817ec52186029ca01f0c082ed84f2dc5ffcc5
    ns2: add support for frame relay
    Change-Id Id3b49f93d33c271f77cd9c9db03cde6b727a4d30

Change-Id: I494a6fb7ccd7938a39e8956f73ec4282da38d7fb