gprs_ns2: remove api call gprs_ns2_dynamic_create_nse
The call was only introduced as workaround for the first implementation
of vty. There is no need for this anymore. The configuration can
just add "accept-ipaccess" to the bind to allow creation of dynamic
ipaccess NSE.
Change-Id: Ie924ead6da17657f3da334068c8ada82c8845495
diff --git a/include/osmocom/gprs/gprs_ns2.h b/include/osmocom/gprs/gprs_ns2.h
index 24f45c9..042e19b 100644
--- a/include/osmocom/gprs/gprs_ns2.h
+++ b/include/osmocom/gprs/gprs_ns2.h
@@ -142,7 +142,6 @@
/* instance */
struct gprs_ns2_inst *gprs_ns2_instantiate(void *ctx, osmo_prim_cb cb, void *cb_data);
void gprs_ns2_free(struct gprs_ns2_inst *inst);
-int gprs_ns2_dynamic_create_nse(struct gprs_ns2_inst *nsi, bool create_nse);
/* Entrypoint for primitives from the NS USER */
int gprs_ns2_recv_prim(struct gprs_ns2_inst *nsi, struct osmo_prim_hdr *oph);
diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c
index 7e273fb..be35513 100644
--- a/src/gb/gprs_ns2.c
+++ b/src/gb/gprs_ns2.c
@@ -874,7 +874,7 @@
if (bind->ll != GPRS_NS2_LL_UDP || dialect != GPRS_NS2_DIALECT_IPACCESS)
return NS2_CS_SKIPPED;
- if (!bind->nsi->create_nse || !bind->accept_ipaccess)
+ if (!bind->accept_ipaccess)
return NS2_CS_SKIPPED;
nse = gprs_ns2_create_nse(bind->nsi, nsei, bind->ll, dialect);
@@ -1208,18 +1208,6 @@
talloc_free(nsi);
}
-/*! Configure whether a NS Instance should dynamically create NSEs based on incoming traffic.
- * \param nsi the instance to modify
- * \param create_nse if NSE can be created on receiving package. SGSN set this.
- * \return 0 on success; negative on error
- */
-int gprs_ns2_dynamic_create_nse(struct gprs_ns2_inst *nsi, bool create_nse)
-{
- nsi->create_nse = create_nse;
-
- return 0;
-}
-
/*! Start the NS-ALIVE FSM in all NS-VCs of given NSE.
* \param[in] nse NS Entity in whihc to start NS-ALIVE FSMs */
void gprs_ns2_start_alive_all_nsvcs(struct gprs_ns2_nse *nse)
diff --git a/src/gb/gprs_ns2_internal.h b/src/gb/gprs_ns2_internal.h
index 027071d..0574cb2 100644
--- a/src/gb/gprs_ns2_internal.h
+++ b/src/gb/gprs_ns2_internal.h
@@ -108,9 +108,6 @@
/*! linked lists of all NSVC in this instance */
struct llist_head nse;
- /*! create dynamic NSE on receiving packages */
- bool create_nse;
-
uint16_t timeout[NS_TIMERS_COUNT];
/*! workaround for rate counter until rate counter accepts char str as index */
diff --git a/src/gb/libosmogb.map b/src/gb/libosmogb.map
index fa05b97..71be117 100644
--- a/src/gb/libosmogb.map
+++ b/src/gb/libosmogb.map
@@ -137,7 +137,6 @@
gprs_ns2_bind_by_name;
gprs_ns2_cause_strs;
gprs_ns2_create_nse;
-gprs_ns2_dynamic_create_nse;
gprs_ns2_find_vc_by_sockaddr;
gprs_ns2_free;
gprs_ns2_free_bind;
diff --git a/utils/osmo-ns-dummy.c b/utils/osmo-ns-dummy.c
index 33949d3..5625f75 100644
--- a/utils/osmo-ns-dummy.c
+++ b/utils/osmo-ns-dummy.c
@@ -229,7 +229,6 @@
exit(1);
}
- gprs_ns2_dynamic_create_nse(nsi, true);
gprs_ns2_vty_init(nsi);
rc = vty_read_config_file(config_file, NULL);
if (rc < 0 && config_given) {