commit 209bc3897434650d341e11cb76d5247cc4ce83f2
author Andreas Eversberg <jolly@eversberg.eu> Wed Jul 19 10:26:27 2023 +0200
committer laforge <laforge@osmocom.org> Wed Jul 26 12:52:30 2023 +0000
tree e730ac30fe35a4e44cf4cb4d63523b4b845131cc
parent d0be3909b88095717271631e957d8a4c13089cd1

ASCI: Add missing check for return value of gsm0808_enc_speech_codec_list2()

Fixes: CID#318987
Change-Id: I771b8ee8dfe1588d0af1c4957489f723447a7054

src/gsm/gsm0808.c

diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c
index 6ba6ef2..529dbdf 100644
--- a/src/gsm/gsm0808.c
+++ b/src/gsm/gsm0808.c
@@ -1756,13 +1756,19 @@
 		msgb_tlv_put(msg, GSM0808_IE_CIRCUIT_POOL_LIST, params->cpl.list_len, params->cpl.pool);
 
 	/* Codec List (BSS Supported) 3.2.2.103 */
-	if (params->codec_list_present)
-		gsm0808_enc_speech_codec_list2(msg, &params->codec_list_bss_supported);
+	if (params->codec_list_present) {
+		if (gsm0808_enc_speech_codec_list2(msg, &params->codec_list_bss_supported) < 0)
+			goto exit_free;
+	}
 
 	/* prepend header with final length */
 	msg->l3h = msgb_tv_push(msg, BSSAP_MSG_BSS_MANAGEMENT, msgb_length(msg));
 
 	return msg;
+
+exit_free:
+	msgb_free(msg);
+	return NULL;
 }
 
 /*! Create BSSMAP VGCS/VBS QUEUING INDICATION message, 3GPP TS 48.008 3.2.1.56.