make all library-internal static buffers thread-local
We have a number of library-internal static global buffers which are
mainly used for various stringification functions. This worked as
all of the related Osmocom programs were strictly single-threaded.
Let's make those buffers at least thread-local. This way every thread
gets their own set of buffers, and it's safe for multiple threads to
execute the same functions once. They're of course still not
re-entrant. If you need re-entrancy, you will need to use the _c()
or _buf() suffix version of those functions and work with your own
(stack or heap) buffers.
Change-Id: I50eb2436a7c1261d79a9d2955584dce92780ca07
diff --git a/src/utils.c b/src/utils.c
index 59dc816..c38f530 100644
--- a/src/utils.c
+++ b/src/utils.c
@@ -41,7 +41,7 @@
*
* \file utils.c */
-static char namebuf[255];
+static __thread char namebuf[255];
/*! get human-readable string for given value
* \param[in] vs Array of value_string tuples
@@ -219,7 +219,7 @@
return nibblepos >> 1;
}
-static char hexd_buff[4096];
+static __thread char hexd_buff[4096];
static const char hex_chars[] = "0123456789abcdef";
/*! Convert binary sequence to hexadecimal ASCII string.
@@ -492,7 +492,7 @@
* sizeof(uint64_t), only the least significant bytes of value are encoded. */
uint8_t *osmo_encode_big_endian(uint64_t value, size_t data_len)
{
- static uint8_t buf[sizeof(uint64_t)];
+ static __thread uint8_t buf[sizeof(uint64_t)];
OSMO_ASSERT(data_len <= ARRAY_SIZE(buf));
osmo_store64be_ext(value, buf, data_len);
return buf;
@@ -908,7 +908,7 @@
*/
const char *osmo_str_tolower(const char *src)
{
- static char buf[128];
+ static __thread char buf[128];
osmo_str_tolower_buf(buf, sizeof(buf), src);
return buf;
}
@@ -967,7 +967,7 @@
*/
const char *osmo_str_toupper(const char *src)
{
- static char buf[128];
+ static __thread char buf[128];
osmo_str_toupper_buf(buf, sizeof(buf), src);
return buf;
}