tree 2b68fd53fe224eac83c91a50c0a4385bac49659c
parent dade018f2fa577de2020c4bfaa9bfde770ae3b30
author Holger Hans Peter Freyther <holger@moiji-mobile.com> 1412954674 +0200
committer Holger Hans Peter Freyther <holger@moiji-mobile.com> 1412956513 +0200

bssgp: Free msgb in case of error when calling into gprs_ns_sendmsg

In the OsmoSGSN we have a crash with a DEAD/BLOCKED GPRS-NS and
segmented SN-UNITDATA. For the caller it is not easy to know if
the passed msg buffer has been freed or not. The most easy solution
is to always take the ownership and either pass it on or free it
in case of an error.

Adjust indirect and direct callers of gprs_ns_sendmsg. I found
the following call-chains with an external msgb parameter.

gprs_ns_sendmsg
  <- _bssgp_tx_dl_ud
     <- bssgp_fc_in
        <- bssgp_tx_dl_ud

Update the test to allocate a real msgb because for the test with
'1000' we will msgb_free it right away.

Sponsored-by: On-Waves ehf