Gitiles
Code Review Sign In
gerrit.osmocom.org / libosmo-abis / b0162077da4d2b60c9006173c11bfab5a0369164
commitb0162077da4d2b60c9006173c11bfab5a0369164[log] [tgz]
authorStefan Sperling <ssperling@sysmocom.de>Tue May 22 18:19:00 2018 +0200
committerStefan Sperling <ssperling@sysmocom.de>Thu May 24 14:57:36 2018 +0200
tree358abd4affc3927b2588a5fc4afd502f38273e31
parent7edc25d9d523b6d16cbf2becd365d83d1da61de9 [diff]
fix double-free/use-after-free of pointers in struct e1inp_line

Ensure that pointers in cloned e1inp_lines point to valid memory.
Some members of struct e1inp_line can simply be deep-copied.
Use talloc reference counting for pointers to objects which may
be shared between clones (driver-private state and counters).
Prevents double-free bugs, e.g. when multiple links referring
to the same line are closed.

Also, do not forget to unlink struct e1inp_line's counter group from
the counter list. Fixes use-after-free in rate_ctr_timer_cb() during
osmo-bts shutdown.

Change-Id: I9f4724b4a5a064801591e9acf4f2fd1db006d082
Related: OS#3011
Related: OS#3137
1 file changed
tree: 358abd4affc3927b2588a5fc4afd502f38273e31
  1. contrib/
  2. debian/
  3. include/
  4. m4/
  5. src/
  6. tests/
  7. .gitignore
  8. .gitreview
  9. AUTHORS
  10. configure.ac
  11. COPYING
  12. git-version-gen
  13. libosmoabis.pc.in
  14. libosmotrau.pc.in
  15. Makefile.am
  16. README.md
  17. TODO-RELEASE
README.md

libosmo-abis - Osmocom Abis interface library

This repository contains a set of C-language libraries that form the A-bis interface library of Osmocom Open Source Mobile Communications projects such as OpenBSC / OsmoBSC.

Historically, a lot of this code was developed as part of the OpenBSC project, but which are of a more generic nature and thus useful to (at least) other programs that we develop in the sphere of Free Software / Open Source mobile communications.

The libosmo-abis.git repository build multiple libraries:

  • libosmoabis contains some abstraction layer over E1/T1 and IP based ETSI/3GPP A-bis interface. It can use mISDN and DAHDI as underlying driver/hardware.
  • libosmotrau contains routines related to A-bis TRAU frame handling

Homepage

The official homepage of the project is https://osmocom.org/projects/libosmo-abis

GIT Repository

You can clone from the official libosmo-abis.git repository using

git clone git://git.osmocom.org/libosmo-abis.git

There is a cgit interface at http://git.osmocom.org/libosmo-abis/

Documentation

There is no Doxygen-generated API documentation yet for this library. It would be great to some day have it, comparable to libosmocore.

Mailing List

Discussions related to libosmo-abis are happening on the openbsc@lists.osmocom.org mailing list, please see https://lists.osmocom.org/mailman/listinfo/openbsc for subscription options and the list archive.

Please observe the Osmocom Mailing List Rules when posting.

Contributing

Our coding standards are described at https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards

We us a gerrit based patch submission/review process for managing contributions. Please see https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit for more details

The current patch queue for libosmo-abis can be seen at https://gerrit.osmocom.org/#/q/project:libosmo-abis+status:open